initFromManifest: a failed adopt of the socket listener should be non-fatal #90
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
server.zig initFromManifest does 'try serve.adopt(d.listener_fd, sock_path)' for the unix socket, so an adopt that fails (path unlinked in the sub-millisecond window around the exec) aborts the upgrade and rolls back. The agent socket's adopt on the same path is non-fatal. With Server.watchSockPath in place, adopting with a lost path and letting the watch re-bind on its first tick is the consistent shape. Review finding 2026-09-05, judged not blocking for the socket-lifecycle branch.
Migrated from git-collab issue
f25709a32c738cbd459aa7ee24b0869d9ce16329.Original author: a73x dev@a73x.sh.