1cb92020

build(ci): the console's types answer to the gate

a73x   2026-08-11 11:55

build(ci): the console's types answer to the gate

Two branches gated green and merged red. One added fleet.test.ts, whose typed
fixtures set every field of a VM as the API describes it; the other dropped
`persistent` from the schema, and so from the generated api-types.ts. Neither
touched a line the other touched, so git merged them without a word, and the
merged tree did not typecheck: a fixture was still setting a field the server
no longer sends. Nothing noticed, because `make ci` ran web-test and not check.

vitest cannot notice. It compiles each module through vite's pipeline, which
strips types rather than checking them — the fixture ran, the assertions
passed, and 24 tests were green on a tree where `npm run check` reported an
error. That is the whole bet the typed fixtures make: api-types.ts is the only
description of the wire the console has, and a fixture that contradicts it is a
type error and nothing else. The bet only pays if something checks types where
the drift happens, which is the merge.

So web-check joins `make ci`, in web-test's idiom: skips with a note when
web/node_modules/.bin/svelte-check is absent, so `make ci` still runs on a
machine with no Node, and CI runs `make web` first, so it is enforced there.
`npm run check` runs `svelte-kit sync` ahead of svelte-check, which is what
lets it pass in a bare worktree — .svelte-kit is gitignored, and generating it
is part of the check rather than a prerequisite the caller has to remember.

Reproduced both ways before landing: with the dropped field put back into the
fixture, web-test passes and `make ci` exits 2 at web-check; with the toolchain
absent, web-check prints its skip and exits 0.