b4239089
Fix T1 code-quality nits from review
alex emery 2026-04-12 06:29
- format_event_detail arm was rendering user-facing text; reduce to a no-op stub grouped with the other unhandled variants. Rendering belongs to the later TUI task. - Test file docstring referenced src/commit_link.rs which doesn't exist yet; scope comment to the variant only.
diff --git a/src/tui/widgets.rs b/src/tui/widgets.rs index 7e8bfbb..1f462d2 100644 --- a/src/tui/widgets.rs +++ b/src/tui/widgets.rs @@ -112,10 +112,10 @@ pub(crate) fn format_event_detail(oid: &Oid, event: &crate::event::Event) -> Str Action::IssueUnassign { assignee } => { detail.push_str(&format!("\nRemoved Assignee: {}\n", assignee)); } Action::IssueCommitLink { commit } => { detail.push_str(&format!("\nCommit: {}\n", commit)); } Action::IssueReopen | Action::PatchMerge | Action::Merge => {} Action::IssueReopen | Action::PatchMerge | Action::Merge | Action::IssueCommitLink { .. } => {} } detail diff --git a/tests/commit_link_test.rs b/tests/commit_link_test.rs index 6197245..9cb6cf3 100644 --- a/tests/commit_link_test.rs +++ b/tests/commit_link_test.rs @@ -1,4 +1,4 @@ //! Unit tests for src/commit_link.rs and the Action::IssueCommitLink variant. //! Unit tests for the Action::IssueCommitLink event variant. use git_collab::event::{Action, Author, Event};