a2b258c9

fix: keep the shellcheck rationale off the directive line

a73x 2026-08-21 08:33

Commit message

fix: keep the shellcheck rationale off the directive line

SC1125: a directive line is key=value pairs to end of line, so the em-dash
rationale parsed as a bad pair and the disable never applied — an error in
current shellcheck, which failed the check step on a file this branch does
not otherwise touch.

test/e2e.sh

Old		New
@@ -697,7 +697,8 @@ converged_quiet() {
697	# would be the function's exit status under `set -e` and a 2-argument	697	# would be the function's exit status under `set -e` and a 2-argument
698	# call would report a divergence it never looked for.	698	# call would report a divergence it never looked for.
699	if [ $# -ge 4 ]; then _sz="--cols $3 --rows $4"; fi	699	if [ $# -ge 4 ]; then _sz="--cols $3 --rows $4"; fi
700	# shellcheck disable=SC2086 — $_sz is two flags or nothing, never data	700	# $_sz is two flags or nothing, never data.
		701	# shellcheck disable=SC2086
701	"$RENDER" $_sz < "$_co" > "$_co.render" \|\| return 1	702	"$RENDER" $_sz < "$_co" > "$_co.render" \|\| return 1
702	"$MUXD" dump --sock "$_cs" > "$_co.dump" \|\| return 1	703	"$MUXD" dump --sock "$_cs" > "$_co.dump" \|\| return 1
703	# Trailing whitespace is a formatting difference between two correct	704	# Trailing whitespace is a formatting difference between two correct
@@ -710,7 +711,8 @@ converged_quiet() {
710	# or a leftover prediction underline — plain text dumps the same glyph	711	# or a leftover prediction underline — plain text dumps the same glyph
711	# either way, which is exactly why plain alone cannot carry M9's	712	# either way, which is exactly why plain alone cannot carry M9's
712	# overlay-never-becomes-state invariant.	713	# overlay-never-becomes-state invariant.
713	# shellcheck disable=SC2086 — same as above: flags or nothing	714	# Same as above: flags or nothing.
		715	# shellcheck disable=SC2086
714	"$RENDER" --vt $_sz < "$_co" > "$_co.rvt" \|\| return 1	716	"$RENDER" --vt $_sz < "$_co" > "$_co.rvt" \|\| return 1
715	"$MUXD" dump --vt --sock "$_cs" > "$_co.dvt" \|\| return 1	717	"$MUXD" dump --vt --sock "$_cs" > "$_co.dvt" \|\| return 1
716	cmp -s "$_co.dvt" "$_co.rvt" \|\| return 1	718	cmp -s "$_co.dvt" "$_co.rvt" \|\| return 1