Strip pre-release legacy compatibility #98

Merged
a73x merged 1 commit from worktree-agent-ac2a9d4b2ce771590 into main 2026-08-14 06:15:15 +00:00
a73x commented 2026-08-14 06:11:51 +00:00 (Migrated from git.a73x.sh)

Removes the ref-layout migration, the ''-means-unknown convention for Revision.commit, the event.rs legacy aliases and signature round-tripping, optional review revisions, the singular relates_to deserializer, the PatchState.labels default, and resolve_head's branch fallback.

Each was confirmed to have zero users first: 'git-collab refs' reports legacy: 0 for this clone, and a field-level audit of all 271 event.json blobs under refs/collab/** found zero 'commit: ""', zero reviews without a revision, and zero legacy variant names. The on-disk fold cache holds no singular relates_to and no PatchState missing labels.

Kept deliberately: Revision.base as Option and effective_base, re-documented as a permanent representation of unknown rather than legacy debt — five revisions in this repository have no recorded base, and no migration can invent one. server/ssh/auth.rs RSA handling is untouched.

A repository still holding a superseded shape now fails loudly, names the ref, and points at 'git-collab refs', which keeps classifying both shapes. sync gained the same guard before its first ref write, because it previously reached git first and produced a directory-vs-file error that named neither the layout nor the remedy.

Full suite green (53 binaries), clippy --all-targets silent, tui_review_test run four times with zero variance.


Migrated from git-collab patche bf948322f6771732f53c83566b307fb4b3bc518f.

Original author: a73x dev@a73x.sh.

Fixes #35

Revision 1: ae48e4fea7a079a1424d7dc6d2c5da88e024f21b; base 969a798355aeb5b0569464ab0659cfbabeb924ba

Removes the ref-layout migration, the ''-means-unknown convention for Revision.commit, the event.rs legacy aliases and signature round-tripping, optional review revisions, the singular relates_to deserializer, the PatchState.labels default, and resolve_head's branch fallback. Each was confirmed to have zero users first: 'git-collab refs' reports legacy: 0 for this clone, and a field-level audit of all 271 event.json blobs under refs/collab/** found zero 'commit: ""', zero reviews without a revision, and zero legacy variant names. The on-disk fold cache holds no singular relates_to and no PatchState missing labels. Kept deliberately: Revision.base as Option and effective_base, re-documented as a permanent representation of unknown rather than legacy debt — five revisions in this repository have no recorded base, and no migration can invent one. server/ssh/auth.rs RSA handling is untouched. A repository still holding a superseded shape now fails loudly, names the ref, and points at 'git-collab refs', which keeps classifying both shapes. sync gained the same guard before its first ref write, because it previously reached git first and produced a directory-vs-file error that named neither the layout nor the remedy. Full suite green (53 binaries), clippy --all-targets silent, tui_review_test run four times with zero variance. --- Migrated from git-collab patche `bf948322f6771732f53c83566b307fb4b3bc518f`. Original author: a73x <dev@a73x.sh>. Fixes #35 Revision 1: `ae48e4fea7a079a1424d7dc6d2c5da88e024f21b`; base `969a798355aeb5b0569464ab0659cfbabeb924ba`
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
a73x/git-collab!98
No description provided.